Fix addToNode resetting plant loop fluid type#5459
Conversation
joseph-robertson
added
severity - Normal Bug
component - Model
Pull Request - Ready for CI
| if (auto plant = node.plantLoop()) { | ||
| if (!plant->demandComponent(node.handle())) { | ||
| return StraightComponent_Impl::addToNode(node); |
src/model/BoilerSteam.cpp
Outdated
| if (auto plant = node.plantLoop()) { | ||
| if (!plant->demandComponent(node.handle())) { | ||
| return StraightComponent_Impl::addToNode(node); |
There was a problem hiding this comment.
Why the switch from plant->supplyComponent to !plant->demandComponent?
What happens if you call it with a supply node on plantloop that's another model? It's NOT a demandComponent, so addToNode is called, when you could have avoided doing it?
There was a problem hiding this comment.
I think BoilerSteam is the weird case here FYI, and ultimately, we should refuse to add it with a warning if done on a PlantLoop that's water/glycol and not steam. But probably do that in #5455
There was a problem hiding this comment.
I was just following the addToNode method for GroundHeatExchangerHorizontalTrench. Sounds like this PR should just change addToNode for GroundHeatExchangerVertical, and leave BoilerHotWater/BoilerSteam alone.
src/model/BoilerHotWater.cpp
Outdated
| } | ||
| if (auto plant = node.plantLoop()) { | ||
| if (!plant->demandComponent(node.handle())) { | ||
| return StraightComponent_Impl::addToNode(node); |
There was a problem hiding this comment.
Curious whether you can use Glycol ones with a BoilerHotWater or not in E+. Have you tried?
There was a problem hiding this comment.
I have not tried.
|
CI Results for 60b9d60:
|
jmarrec
left a comment
jmarrec
left a comment
There was a problem hiding this comment.
I guess now this is just for GroundHeatExchangerVertical now that boilers have been reverted, and I'm ok with it. Not sure whether that fixes ALL of the original issue or not, but I want to reduce the number of open PRs so let's drop it.
3 participants
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.